feat: add websocket auto-reconnect, resubscribe, and re-auth#3
Open
harley-poly wants to merge 5 commits into
Open
feat: add websocket auto-reconnect, resubscribe, and re-auth#3harley-poly wants to merge 5 commits into
harley-poly wants to merge 5 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mustafa-poly
approved these changes
Jun 2, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8b3f32d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
makes the private and markets websockets resilient to dropped connections:
auto_reconnect=Trueby default;reconnect_max_attemptsconfigurable).subscribe/unsubscribeso they can be replayed; areconnectevent fires after a successful reconnect.websocketsexception shapes.note: per the server protocol,
order/position/tradestreams don't replay history on resubscribe (market-data and account-balance snapshots are re-sent automatically); useSUBSCRIPTION_TYPE_ORDER_SNAPSHOTto refetch open orders after a reconnect.test plan
ruff check/ruff format --checkmypy polymarket_uspytest(127 passed; newtests/test_websocket_reconnect.pycovers subscription tracking, resubscribe replay, transient-then-success reconnect, fatal-auth stop, max-attempts, and the upgrade-status helper)Note
Medium Risk
Changes live streaming connection semantics for authenticated trading and market feeds; missed or stale order/position state is possible if callers ignore the documented non-replay behavior after reconnect.
Overview
WebSocket clients (private and markets) now recover from unexpected disconnects by default: exponential backoff with jitter, a fresh signed upgrade on each attempt, and automatic replay of every subscription still registered via
subscribe(cleared onunsubscribe). Successful recovery emits areconnectevent;auto_reconnectandreconnect_max_attemptstune behavior, and upgrade failures 401/403/429 stop retries instead of looping.The README documents that
order/position/tradestreams do not replay historical updates after reconnect (snapshots for market data and balances are described as automatic; open orders may need an order snapshot subscription).Supporting changes:
close()cancels the background run/reconnect task; socket cleanup before retry avoids leaks;MarketsWebSocket/PrivateWebSocketaccept broader constructor kwargs for reconnect options; auth test fix for 64-byte keys; newtests/test_websocket_reconnect.pycoverage.Reviewed by Cursor Bugbot for commit 49bd5d1. Bugbot is set up for automated code reviews on this repo. Configure here.